Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RO terms that normalize but the "invertedness" is not reported #7

Open
saramsey opened this issue Jul 15, 2020 · 8 comments
Open

RO terms that normalize but the "invertedness" is not reported #7

saramsey opened this issue Jul 15, 2020 · 8 comments
Assignees

Comments

@saramsey
Copy link

saramsey commented Jul 15, 2020

When I attempt to normalize RO:0001022 ("has allergenic trigger"), I get biolink:causes, which I think is close, but not quite correct (I think it should be the inverse of that).

curl -X GET "https://edgenormalization-sri.renci.org/resolve_predicate?predicate=RO%3A0001022&version=latest" -H  "accept: application/json"

Screen Shot 2020-07-15 at 2 28 33 PM

The Relation Ontology (RO) has "inversion" encoded in their hierarchy relationships, as shown in Ontobee:

Screen Shot 2020-07-15 at 2 43 08 PM

were these taken into account in the ETL of RO that was (presumably) done to generate the synonym relationships in the Edge Normalizer?

@saramsey
Copy link
Author

This is causing inverted relationships in KG2 that lead to strange results, like "shellfish allergy" causes "shellfish".

@cbizon
Copy link
Contributor

cbizon commented Jul 16, 2020

Ah, this is an excellent point. We'll get on it.

@cbizon cbizon self-assigned this Jul 16, 2020
@cbizon
Copy link
Contributor

cbizon commented Jul 16, 2020

Well, having dug in a little, and talked to @balhoff I think that this is actually an RO bug. Both has allergic trigger and has autoimmune trigger seem to have an incorrect superproperty.

@saramsey if you know that RO really encodes inverses as part of a property inheritance, can you explain how it's coded there?

I'll file a bug report at RO and see what they say. Leaving this issue open until I hear from them.

@cbizon
Copy link
Contributor

cbizon commented Jul 16, 2020

oborel/obo-relations#380

@saramsey
Copy link
Author

saramsey commented Jul 17, 2020

Hi @cbizon thanks for your thoughtful reply. I guess I should restate my claim: I surmised that RO encodes this information because it seems to be available in Ontobee (see screencap in the OP), see the plusses and minuses in the treeview. Apologies if I've misinterpreted the meaning of the plusses & minuses.

http://www.ontobee.org/ontology/RO?iri=http://purl.obolibrary.org/obo/RO_0001023

@saramsey
Copy link
Author

saramsey commented Jul 17, 2020

Also thanks to @balhoff for consulting on this issue.

@cbizon
Copy link
Contributor

cbizon commented Jul 20, 2020

Ok, I think (not 100% sure) that the +/- on ontobee indicates whether the term has children (+) or not (-).

@balhoff
Copy link

balhoff commented Jul 20, 2020

Ok, I think (not 100% sure) that the +/- on ontobee indicates whether the term has children (+) or not (-).

@cbizon that's right. If there is an inverse property, it is stated in a "Inverse Properties" section further down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants