Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation in GUI should be "in process" by default? #142

Open
sudara opened this issue Dec 4, 2024 · 2 comments
Open

Validation in GUI should be "in process" by default? #142

sudara opened this issue Dec 4, 2024 · 2 comments

Comments

@sudara
Copy link
Collaborator

sudara commented Dec 4, 2024

Scanning is nice out of process, but I think it's a common papercut to have to manually check "in process" to get good stack traces.

I personally never run the GUI out of process. But I have been caught out by it not being the default. Thoughts?

@drowaudio
Copy link
Contributor

This might be a throwback of how pluginval originally ran but does "in-process" still mean in the same process as the gui?

If so, that's probably not what you want right? As it will kill the app and only give you a stack trace if you happen to be attached to a debugger?

@sudara
Copy link
Collaborator Author

sudara commented Dec 5, 2024

Do you ever run pluginval locally without the debugger attached?

95% of the time I'm doing this:

  • CI has a validation failure or crash
  • I build and run pluginval locally, with debugger attached to diagnose

As described here:

https://github.com/Tracktion/pluginval/blob/develop/docs/Debugging%20a%20failed%20validation.md#quick-debugging

But you are right, if someone is checking out pluginval for the first time, downloads the release zip and in-process is default, their plugin crashing would crash pluginval.

In-process could be the default for Debug mode. The assumption being if you are building locally, you are debugging... Hm...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants