Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beta Prep #4

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Beta Prep #4

wants to merge 19 commits into from

Conversation

mosesintech
Copy link
Contributor

@mosesintech mosesintech commented Jun 23, 2023 •
edited
Loading

This PR will

  • update README
  • update id to databaseId in form fields.
  • add declaration files to dist
  • expand debugging
  • fix known bugs
  • add email confirmation field
  • add requiredIndicator and customRequiredIndicator to form fields

When merged, v1.0.0-beta will be ready to be published.

@mosesintech
fix(fields): update id to databaseId in form fields
96d1d46
@mosesintech
fix(example): update id to databaseId in example
c788bdf
@mosesintech
fix(tsconfig): add declaration files to dist
34f6314
@mosesintech
fix(publish.config.js): fix missing declaration file
bc1524d
@mosesintech
feat(declaration file): fix missing declaration file in alpha
926d770
@mosesintech
feat(debug): add state to ui and console log debugging
13ae900
@mosesintech
fix(text): fix validation rules in text and text area
6b19b1d
@mosesintech
feat(button): add disabledButtonClass to Button component
b4a34e8
@mosesintech
fix(text): fix text and text area validation error when empty && not …
edf55b4 
…required
@mosesintech
feat(button): add disableButtonClass
8293b34
@mosesintech
fix(form): add blank string as default value for all fields
2108f4b 
Even if the field was not required, the mutation expected at least an empty string.
@mosesintech
feat(email): add email confirmation field
3696c73
@mosesintech
feat(email): add confirmation message to validation rules for email c…
ed7fcf4 
…onfirmation field
@mosesintech
fix(email): refactor for confirmMessage and fix hidden defaultValue bug
9b6d798
@mosesintech
fix(captcha): fix Captcha field typing errors
dfaf7ea
@mosesintech
fix(consent): fix missing consent mutation default value
400475c
@mosesintech
fix(button): fix missing styles when disabled
9c68a30
@mosesintech
fix(fields): move classes prop to input fields instead of wrapping div
7a517e5 
This does not affect Address, Captcha, Consent, FileUpload, Hidden, HTML, Name, Page, Radio,
Section, or Select
@mosesintech
feat(fields): add requiredIndicator and customRequiredIndicator
ae0b236 
This commit also fixed the typing issue we had with strings to unions regarding captcha, and fixed
Consent field missing from requiredFields.
@mosesintech mosesintech linked an issue Sep 20, 2023 that may be closed by this pull request
Add Required Field Indicator Setting Support #15
Open
@mosesintech
Copy link
Contributor Author

This last commit adds the requiredIndicator and customRequiredIndicator feature mentioned in #15.

It also adds an indicatorClass prop to the GravityForm component so devs can style the indicator like they want.

When requiredIndicator is "TEXT", or "CUSTOM" and customRequiredIndicator is null, the indicator is Required with an intentional space before the word. This may change if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Required Field Indicator Setting Support
1 participant
@mosesintech