Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Telnet with SSH #2146

Open
Hockeyfan360 opened this issue Jan 8, 2018 · 5 comments
Open

Replace Telnet with SSH #2146

Hockeyfan360 opened this issue Jan 8, 2018 · 5 comments

Comments

@Hockeyfan360
Copy link
Contributor

http://totalfreedom.boards.net/thread/57950/replace-telnet-ssh-bukkittelnet

SSH is a significantly more modern and secure protocol than telnet. The Apache Mina SSHD project is a library that lets you embed SSHD servers into Java applications. This is exactly what we would need for this project.

We would need to implement a custom PasswordAuthenticator service. Seeing as the PasswordAuthenticator interface passes a session object, you can probably verify IPs, too. I'll look into that later. After that, we just write to each session as Telnet does.

For logs: getAllSessions(), for each AbstractSession, writePacket(stuff).
For commands: Again, I'll figure that out later.

It's a fairly difficult project. However, it is very doable.

https://mina.apache.org/sshd-project/embedding_ssh.html
https://mina.apache.org/sshd-project/apidocs/

@script-head
Copy link
Contributor

script-head commented Jan 8, 2018

We'd have to rewrite almost everything related to telnet and re-make clients for this as many people probably wouldn't want to looking at black on white.

@Hockeyfan360
Copy link
Contributor Author

Hockeyfan360 commented Jan 8, 2018

^ Yeah, it is a hurdle. And to be completely honest, I'm not sure it's worth it either. Yes, it's more secure than telnet, but we're losing a lot of functionality for a small gain. This is just a discussion thread, and I'm interested to see what others think, too.

@JeromSar
Copy link
Member

JeromSar commented Jan 8, 2018

I've thought of this before, and I like the idea very much. It just needs time and someone willing to implement it. It shouldn't be too hard but may require a little cleverness here and there. However, there are currently much more important issues that we should be focusing on.

@Wild1145
Copy link
Member

Wild1145 commented Jan 8, 2018

Im certainly open to the idea, though given Telnet has been retired for many years already I dont think we need to rush to change it just because people suddenly realise its not the most modern system.

@Wild1145
Copy link
Member

https://dev.bukkit.org/bukkit-plugins/sshd - A plugin that we could probably use and integrate with for the server side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants