New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix option checking for Transcription Service #81

Open

TomFrankly opened this issue Mar 28, 2024 · 0 comments

Labels

bug

Owner

TomFrankly commented Mar 28, 2024

This line should be changed:

// Set the full transcript based on which transcription service was used
		fileInfo.full_transcript =
			this.transcription_service === "OpenAI"
				? await this.combineWhisperChunks(fileInfo.whisper)
				: fileInfo.deepgram.raw_transcript;

The user can accidentally clear the Transcription Service option, so we should explicitly check for a value and pre-throw an error if it's not there.

https://github.com/TomFrankly/pipedream-notion-voice-notes/blob/main/Notion-Voice-Notes.mjs#L2392C3-L2396C40

The text was updated successfully, but these errors were encountered:

TomFrankly added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment