Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: update act_param to dictionary #18

Closed
amindadgar opened this issue Oct 17, 2023 · 0 comments · Fixed by #19
Closed

improvement: update act_param to dictionary #18

amindadgar opened this issue Oct 17, 2023 · 0 comments · Fixed by #19
Assignees

Comments

@amindadgar
Copy link
Member

amindadgar commented Oct 17, 2023

The act_param we're using now is an array of integers which it isn't possible to find out which value is related to which analytics. For example, we have an array of [1, 1, 1, 4, 3, 5, 5, 4, 3, 2, 2, 2, 1] which the first value is the minimum number of interactions to be active, and other values each representing the parameter for other analytics.

To make it more transparent, we're gonna update the array to a python dictionary (json object) as below

act_param = {
    "INT_THR": 1,
    "UW_DEG_THR": 1,
    "PAUSED_T_THR": 1,
    "CON_T_THR": 4,
    "CON_O_THR": 3,
    "EDGE_STR_THR": 5,
    "UW_THR_DEG_THR": 5,
    "VITAL_T_THR": 4,
    "VITAL_O_THR": 3,
    "STILL_T_THR": 2,
    "STILL_O_THR": 2,
    "DROP_H_THR": 2,
    "DROP_I_THR": 1,
}

This update includes additional code updates which would be on the module assess_engagement.py

@amindadgar amindadgar self-assigned this Oct 17, 2023
@amindadgar amindadgar linked a pull request Oct 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant