-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String resources #1073
Comments
Do we really need this though? It will definitely help non-programmers with changing string values across the code without delving into it but I don't know if it's going to be a good investment. I thought that usually mostly people do this for i18n purposes but I'd love to hear other's opinions about this as well. :) |
I think there's something to be said for both sides. A lot of inline text can be more challenging to support, on the other hand the filename does also serve as a certain reassurance that they're in the right spot. Out of curiousity, why an XML file, and not just https://docs.oracle.com/en%2Fjava%2Fjavase%2F22%2Fdocs%2Fapi%2F%2F/java.base/java/util/ResourceBundle.html + a properties file? |
Issue
We have a lot of strings embedded into the code which is hard to manage. And it will only get worse with time.
To update a string we have to know which class to look into and find the exact line the string is created in. This is a hard task, especially for a non-programmer person.
Solution
Make an android-like
R.java
class that will read the strings/string templates from the XML resource file and use it in the code. Also, add a guide on how to find and update text in the wiki.The text was updated successfully, but these errors were encountered: