Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take a regex to identify the icon file in webpackIsomorphicParser #2

Open
jetpacmonkey opened this issue Jan 25, 2017 · 0 comments
Open

Take a regex to identify the icon file in webpackIsomorphicParser #2

jetpacmonkey opened this issue Jan 25, 2017 · 0 comments
Labels
enhancement

Comments

@jetpacmonkey
Copy link
Contributor

Currently, webpackIsomorphicParser has a hard-coded const iconsFileRE = /icons-[a-f0-9]+\.svg/i;. Ideally, there'd be some way for the parser to access the plugin from the webpack config, and get the filename from there. A slightly lesser solution would be to simple take in the same pattern that the plugin does, and let the user deal with keeping that in sync.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jetpacmonkey