Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make icon file's public path configurable #1

Open
jetpacmonkey opened this issue Jan 25, 2017 · 0 comments
Open

Make icon file's public path configurable #1

jetpacmonkey opened this issue Jan 25, 2017 · 0 comments

Comments

@jetpacmonkey
Copy link
Contributor

Right now, the generated icon file is expected to be found inside the /static directory. My original rationale for using that instead of the publicPath in the webpack config was because <use> tags don't support cross-origin requests, and publicPath is often used to set to a CDN's domain. A better, more widely usable solution would be to take a config option in the plugin's constructor, have publicPath as a setting, and fallback to the webpack default publicPath if one is not specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant