Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ErrorLogs] Improvements #88

Open
TrustyJAID opened this issue Jun 21, 2023 · 1 comment · May be fixed by #90
Open

[ErrorLogs] Improvements #88

TrustyJAID opened this issue Jun 21, 2023 · 1 comment · May be fixed by #90

Comments

@TrustyJAID
Copy link

Hi Toby, I have some improvements for ErrorLogs I would like to contribute but as per your front page you suggest an issue before a PR.
image
This is what I had in mind. It adds support for hybrid slash commands providing the full context of the command. This is mainly due to ctx.message.content being empty on these new command types and knowing what was passed is helpful. I also took the liberty to rearrange some things since discord renders jump urls a lot nicer now and I put it on a new field. Moving the content to the description field allows for the potential of a command having more than 1024 characters actually appearing correctly. Prior, if there happened to be a command that ended up being more than 1024 characters it would fail to properly send the error log. Embed descriptions are allowed to be 4096 characters and nitro users can send up to 4000 characters.

Let me know what you think of these changes!

@Tobotimus
Copy link
Owner

Hey @TrustyJAID, this looks awesome! Thanks for opening the issue. I'd be grateful for a PR with these changes :)

@TrustyJAID TrustyJAID linked a pull request Jul 2, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants