Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow creating a ruleset to require the Prod Environment Sync job to succeed before merging to main is allowed #3419

Open
Ben-Epstein opened this issue Nov 24, 2024 · 1 comment

Comments

@Ben-Epstein
Copy link

I'm trying to use the synchronized CI/CD workflow but i'm running into 1 specific issue.

I'd like to enforce that the Prod Environment Synced check is passing before merge. I have done that in a toy example here, but the issue is that requiring that to pass before merging actually causes it to fail, because it tries to merge the PR after the prod sync happens, but because it didnt send out a passing signal yet, github blocks it.

I don't want people accidentally merging PRs before the deploy step occurs - that defeats the purpose of the synchronized workflow's benefits.

The feature request is to modify the Prod Environment Sync job such that we can create a ruleset around it that would force its success before merging.

Thank you!

@georgesittas
Copy link
Contributor

georgesittas commented Nov 27, 2024

Hey @eakmanrq, perhaps you can help here? Should we mark this as feature/improvement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants