Add classes for Task and SharedTask in threadpool #5391
+315
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
ThreadPool::Task
is a typedef tostd:: future<Status>
. This PR:wait
for our async processes to go through our ThreadPool's wait method. In that way, we never use astd::future
'swait
method directly and we avoid possible deadlocks because only the ThreadPool'swait
will yield.SharedTask
, that is encapsulatingstd::shared_future
which allows multiple threads to wait on an async operation result to become available. This is needed for the upcoming work on parallelizing IO and compute operations in the codebase even further.This is heavily influenced from similar work by @Shelnutt2.
TYPE: IMPROVEMENT
DESC: Add classes for Task and SharedTask in threadpool