Move counts computation to aggregate_with_count. #4401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #33757: [Refactor] Aggregates: move null-count and count computation to common compute class.. |
KiterLuc
force-pushed
the
lr/counts-agg-to-agg-w-sum/ch33757
branch
3 times, most recently
from
c74f083 to
3159ba2
Compare
This moves the computation for the count aggregators to aggregate_with_count. It also merges the unit test with the existing ones for other aggregators. TYPE: IMPROVEMENT DESC: Move counts computation to aggregate_with_count.
KiterLuc
force-pushed
the
lr/counts-agg-to-agg-w-sum/ch33757
branch
from
3159ba2 to
447f5c8
Compare
robertbindar
suggested changes
Oct 13, 2023
| @@ -96,4 +88,18 @@ void CountAggregator::copy_to_user_buffer( | |||
| } | |||
| } | |||
|
|
|||
| NullCountAggregator::NullCountAggregator(FieldInfo field_info) | |||
| : CountAggregatorBase(field_info) | |||
There was a problem hiding this comment.
The architecture here is slightly off, NullCountAggregator should be the derived that has a constructor based on FieldInfo (which also performs the checks) and CountAggregatorBase, CountAggregator should have a default constructor. This will avoid the weird FieldInfo("","",false) which tries to replace a default constructed FieldInfo which we explicitly deleted.
robertbindar
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the computation for the count aggregators to aggregate_with_count. It also merges the unit test with the existing ones for other aggregators.
TYPE: IMPROVEMENT
DESC: Move counts computation to aggregate_with_count.