Implement tiledb_handle_load_array_schema_request #4399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #34939: Write tests for tiledb_handle_load_array_schema_request. |
davisp
force-pushed
the
pd/sc-34939/add-tiledb-handle-load-array-schema-request
branch
from
4121b04 to
4ac6af0
Compare
This adds all of the Capnp messages, serialization code, rest client functions, and server side request processing for handling the new load array schema handler. Notably, this does not update `tiledb_array_schema_load` to use these new functions because that cannot happen until after TileDb-Cloud-REST is deployed with a libtiledb that contains this commit.
davisp
force-pushed
the
pd/sc-34939/add-tiledb-handle-load-array-schema-request
branch
from
4ac6af0 to
ea40a36
Compare
KiterLuc
approved these changes
Oct 6, 2023
| data.reset_size(); | ||
| data.reset_offset(); | ||
|
|
||
| switch (serialization_type) { |
There was a problem hiding this comment.
I see a lot of these switch cases in the serialization code... Is this something we could generalize? If so, let's file a follow up story I don't want to block this PR for this.
There was a problem hiding this comment.
I copied this from the prior art in other places. I do think this whole function could probably be turned into a template though since they're pretty boiler plate without a lot of changes for different message types.
KiterLuc
deleted the
pd/sc-34939/add-tiledb-handle-load-array-schema-request
branch
This was referenced Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds all of the Capnp messages, serialization code, rest client functions, and server side request processing for handling the new load array schema handler.
Notably, this does not update
tiledb_array_schema_loadto use these new functions because that cannot happen until after TileDb-Cloud-REST is deployed with a libtiledb that contains this commit.TYPE: C_API
DESC: Implement tiledb_handle_load_array_schema_request