Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align comments with clang-format-16 #4398

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Conversation

eric-hughes-tiledb
Copy link
Contributor

@eric-hughes-tiledb eric-hughes-tiledb commented Oct 4, 2023

Running clang-format-16 locally aligns trailing comments differently than what's already in dev. Furthermore, the directive AlignTrailingComments changed from its old value (boolean) to one with more parameters. This PR updates .clang-format for that directive. Hopefully this reduces any variation between local and CI installations.


TYPE: NO_HISTORY
DESC: clang-format-16

Running `clang-format-16` locally aligns trailing comments differently than what's already in `dev`. Furthermore, the directive `AlignTrailingComments` changed from its old value (boolean) to one with more parameters. This PR updates `.clang-format` for that directive and includes the files changed by the formatting. Hopefully this reduces any variation between local and CI installations.
@eric-hughes-tiledb eric-hughes-tiledb force-pushed the eh/clang-format-16-align-comments branch from 68bbf12 to 7274e27 Compare October 4, 2023 18:38
@eric-hughes-tiledb eric-hughes-tiledb marked this pull request as ready for review October 5, 2023 00:56
@KiterLuc KiterLuc merged commit 8180462 into dev Oct 5, 2023
52 checks passed
@KiterLuc KiterLuc deleted the eh/clang-format-16-align-comments branch October 5, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants