Remove class Status from exception handler.
#4393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #33024: Nested exceptions are hidden from C API error messages. |
…erted old visitor base class into a concept.
eric-hughes-tiledb
force-pushed
the
eh/nested_exception_action
branch
from
6395842 to
16e9cdb
Compare
KiterLuc
approved these changes
Oct 6, 2023
ihnorton
pushed a commit
that referenced
this pull request
Oct 13, 2023
* Switch from inheritance to templates for the error tree visitor. Converted old visitor base class into a concept. * Adjusted C API build to take into account that the exception handler is no longer header-only. * More build adjustments * Attempt to remove a duplicate symbol linkage causing CI fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop converting exceptions to
class Statusin the exception handler. Replace it with direct handling of the exception. The new handler captures messages instd::nested_exception.Rename
CAPIStatusExceptiontoCAPIException. Remove no-longer-used code. UpdatedCMakeLists.txtfor the exception wrapper tests.[sc-33024]
TYPE: IMPROVEMENT
DESC: Logs for nested exceptions now incorporate all messages.