Fix and optimize the Release CI workflow. #4373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combining this option with enabling vcpkg causes the dependencies to build with both vcpkg and ExternalProjects. Disabling it causes only vcpkg to be used, which builds everything either way.
Apparently vcpkg has trouble detecting it by itself.
ihnorton
reviewed
Sep 20, 2023
Co-authored-by: Isaiah Norton <[email protected]>
KiterLuc
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes failures in the Release workflow on macOS and arm64. #4348 started using vcpkg to detect the current triplet, but due to a bug it thought we were building for x64-osx. I reverted part of the previous logic for macOS.
Also, I noticed that the Release workflow was building the
ExternalProjects for some of our dependencies, even while vcpkg was enabled, causing them to be built twice. This happened because we were enablingTILEDB_FORCE_ALL_DEPS. I stopped passing the option and marked it as incompatible withTILEDB_VCPKG.I launched a run of the
Build_Releasejob and it succeeds (https://dev.azure.com/TileDB-Inc/CI/_build/results?buildId=35084&view=results).TYPE: BUILD
DESC: Fix and optimize the Release CI workflow.