[cppapi] Fix sc-34380: don't error out if DELETE symbol is defined #4365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #34380: Don't expose DELETE error in public C++ API. |
We can avoid conflicting with the DELETE symbol by creating it, using token-pasting.
ihnorton
force-pushed
the
ihn/sc-34380/dont-police-delete-symbol
branch
from
283e6b0 to
ddee727
Compare
eric-hughes-tiledb
approved these changes
Sep 19, 2023
ihnorton
added a commit
that referenced
this pull request
Sep 20, 2023
…4365) (#4372) We can avoid conflicting with the DELETE symbol by creating it, using token-pasting. --- TYPE: CPP_API DESC: Don't error out if DELETE symbol is defined. (cherry picked from commit 31687b6) Co-authored-by: Isaiah Norton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can avoid conflicting with the DELETE symbol by creating it, using token-pasting.
TYPE: CPP_API
DESC: Don't error out if DELETE symbol is defined.