Fix Enumeration API when passed std::vector<bool> #4362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #34308: [CORE] Support |
KiterLuc
approved these changes
Sep 18, 2023
I forgot to account for the fact that `std::vector<bool>` is a specialized template which uses an internal bitmap instead of a standard backing array.
davisp
force-pushed
the
pd/sc-34308/fix-bool-enumeration-creation
branch
from
0b1e5d3 to
c9abd5a
Compare
ihnorton
pushed a commit
that referenced
this pull request
Sep 22, 2023
I forgot to account for the fact that `std::vector<bool>` is a specialized template which uses an internal bitmap instead of a standard backing array. (cherry picked from commit 41bc0f2)
ihnorton
pushed a commit
that referenced
this pull request
Sep 24, 2023
I forgot to account for the fact that `std::vector<bool>` is a specialized template which uses an internal bitmap instead of a standard backing array. (cherry picked from commit 41bc0f2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to account for the fact that
std::vector<bool>is a specialized template which uses an internal bitmap instead of a standard backing array.Also note that boolean enumerations can be created, they just have to use a
std::vector<uint8_t>and manually specify the data type like such:TYPE: BUG
DESC: Fix creation of Enumerations with
std::vector<bool>