Add regression tests for sc-33912 #4358
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I could use another set of eyes here. I'm writing regression test for SC-33912 and struggling to reproduce similar failures based on this comment. I wrote some comments above each TEST_CASE to summarize what I'm seeing.
Validating the default coords filters are applied to the dimension with no filters is no problem, but I was expecting to see some failures validating the read query, similar to the incorrect result counts from VCF?
TYPE: IMPROVEMENT
DESC: Add regression tests for sc-33912