Backwards compatibility: handle 0 chunk var tiles. #4310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #33480: [TileDB Cloud crash dumps] ReaderBase::compute_chunk_min_max.. |
In arrays with format version earlier than 10, it was possible to create a var file with zero chunks when all cells had an empty string value. This caused segfaults with later versions of the library and is fixed with this change. --- TYPE: BUG DESC: Backwards compatibility: handle 0 chunk var tiles.
KiterLuc
force-pushed
the
lr/zero-chunk-var-file/ch33480
branch
from
69ac408 to
ce00ab9
Compare
Shelnutt2
reviewed
Sep 1, 2023
|
I'm having a hard time getting the "comment on file" to stick with GitHub, so one more item. Can we put the code used to generate the test input array as a comment somewhere in code ?This way if we need to recreate it in the future we know how it was originally produced. |
KiterLuc
requested review from
Shelnutt2 and
davisp
and removed request for
davisp
ihnorton
reviewed
Sep 1, 2023
ihnorton
requested changes
Sep 2, 2023
ihnorton
approved these changes
Sep 2, 2023
Co-authored-by: Isaiah Norton <[email protected]>
Co-authored-by: Isaiah Norton <[email protected]>
KiterLuc
added a commit
that referenced
this pull request
Sep 4, 2023
* Backwards compatibility: handle 0 chunk var tiles. In arrays with format version earlier than 10, it was possible to create a var file with zero chunks when all cells had an empty string value. This caused segfaults with later versions of the library and is fixed with this change. --- TYPE: BUG DESC: Backwards compatibility: handle 0 chunk var tiles. * Add unit tests. * Adding array creation code. * Move test to regression tests. * Adding note for mac m1. * Update test/regression/CMakeLists.txt Co-authored-by: Isaiah Norton <[email protected]> * Update test/regression/targets/sc-33480.cc Co-authored-by: Isaiah Norton <[email protected]> --------- Co-authored-by: Isaiah Norton <[email protected]> (cherry picked from commit c0e4a0e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In arrays with format version earlier than 10, it was possible to create a var file with zero chunks when all cells had an empty string value. This caused segfaults with later versions of the library and is fixed with this change.
TYPE: BUG
DESC: Backwards compatibility: handle 0 chunk var tiles.