Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tiledb_array_schema_load_with_enumerations #4304

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

davisp
Copy link
Contributor

@davisp davisp commented Aug 30, 2023

Removing the relatively obscure feature for loading array schema with all enumerations. This will be re-implemented using a completely new TileDB Cloud REST HTTP endpoint in the future.


TYPE: NO_HISTORY
DESC: Remove tiledb_array_schema_load_with_enumerations

Removing the relatively obscure feature for loading array schema with
all enumerations. This will be re-implemented using a completely new
TileDB Cloud REST HTTP endpoint in the future.
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #33587: [CORE] Remove array_from_uri with enumerations support.

@davisp davisp requested a review from Shelnutt2 August 30, 2023 19:34
@Shelnutt2
Copy link
Member

The goal is to replace it with a generic function that will allow loading the array schema along with other parameters and will be future proof and enable support for time traveling.

@davisp
Copy link
Contributor Author

davisp commented Aug 31, 2023

My bad on being terse on context. The planned replacement for this is the obvious path forward so there's not reason to incur the debt this would cost just for one release.

Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@ihnorton ihnorton merged commit 70ad7bb into dev Aug 31, 2023
54 checks passed
@ihnorton ihnorton deleted the pd/sc-33587/remove-array-from-uri-with-enumerations branch August 31, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants