Implement v1 serialization for Enumerations #4288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #32981: [CORE] Add load enumeration request API. |
Shelnutt2
reviewed
Aug 18, 2023
Shelnutt2
reviewed
Aug 18, 2023
davisp
force-pushed
the
pd/sc-32981/add-handle-load-enumerations-api
branch
2 times, most recently
from
9069c40 to
40ce91e
Compare
davisp
force-pushed
the
pd/sc-32981/add-handle-load-enumerations-api
branch
2 times, most recently
from
40ce91e to
e99fd24
Compare
davisp
changed the title
davisp
force-pushed
the
pd/sc-32981/add-handle-load-enumerations-api
branch
5 times, most recently
from
d55ede4 to
ab8e71f
Compare
The previous version of loading enumerations accidentally exposed the concept of multiple array schemas to users of the C API which was a first. Even though it was only a boolean flag, it was still crossing a line in our API model so it has been removed. This also changes how the ArrayDirectory loads enumerations slightly so that loading multiple enumerations is done in parallely any time more than one enumeration is required.
davisp
force-pushed
the
pd/sc-32981/add-handle-load-enumerations-api
branch
from
ab8e71f to
204ee99
Compare
This change adds support for the new tiledb_handle_load_enumerations_request and adds the corresponding REST client APIs to make use of it. The changes in this PR cannot be tested directly until after TileDB-Cloud-REST has merged support for the new HTTP endpoint that will connect these two new functions. Although I have tested these locally using REST-CI tests and the basic tests all pass just fine.
davisp
force-pushed
the
pd/sc-32981/add-handle-load-enumerations-api
branch
from
204ee99 to
c40b92a
Compare
Shelnutt2
approved these changes
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for the new
tiledb_handle_load_enumerations_request and adds the corresponding REST
client APIs to make use of it. The changes in this PR cannot be tested
directly until after TileDB-Cloud-REST has merged support for the new
HTTP endpoint that will connect these two new functions. Although I have
tested these locally using REST-CI tests and the basic tests all pass
just fine.
TYPE: IMPROVEMENT
DESC: Add tiledb_handle_load_enumerations_request