Add group backwards compatibility tests #3996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #26763: Add backwards-compatibility testing for Groups. |
teo-tsirpanis
force-pushed
the
group-backwards-compat
branch
from
0470f7c to
334e073
Compare
teo-tsirpanis
changed the title
|
@KiterLuc the backwards compatibility tests are green. |
KiterLuc
reviewed
Oct 3, 2023
| "[backwards-compat][group][metadata]") { | ||
| Context ctx; | ||
| std::string compat_folder(arrays_dir + "/read_compatibility_test"); |
There was a problem hiding this comment.
NIT: We've seen bugs introduced this way... Let's avoid single line if/for/while... Always have the body between brackets. There are a couple places to fix in this function.
KiterLuc
changed the title
KiterLuc
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-26763
TYPE: IMPROVEMENT
DESC: Add group backwards compatibility tests.