Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Core to 2.27. #495

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Update Core to 2.27. #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5f2b62
Regenerate bindings for 2.27.
teo-tsirpanis Nov 23, 2024
5d9814f
Deprecate filestore APIs.
teo-tsirpanis Nov 25, 2024
53a228b
Use `tiledb_group_dump_str_v2`.
teo-tsirpanis Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions docs/obsoletions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Following [the deprecation policy of TileDB Embedded][core-deprecation], obsolet
|[`TILEDB0012`](#TILEDB0012) …[`TILEDB0013`](#TILEDB0013)|5.7.0|5.9.0|
|[`TILEDB0014`](#TILEDB0014) …[`TILEDB0014`](#TILEDB0014)|5.8.0|5.10.0|
|[`TILEDB0015`](#TILEDB0015) …[`TILEDB0015`](#TILEDB0015)|5.13.0|5.15.0|
|[`TILEDB0015`](#TILEDB0016) …[`TILEDB0015`](#TILEDB0016)|5.17.0|5.19.0|

## `TILEDB0001` - Enum value names that start with `TILEDB_` were replaced with C#-friendly names.

Expand Down Expand Up @@ -363,4 +364,18 @@ The `ConfigIterator` class is unintuitive to use. In version 5.13.0 it was marke

Replace uses of `ConfigIterator` with enumerating the `Config` object directly using a `foreach` loop or LINQ. To get only the config options that start with a specific prefix, call the `Config.EnumerateOptions` method and enumerate its returned object.

## `TILEDB0016` - `File` is obsolete.

<a name="TILEDB0016"></a>

The TileDB filestore APIs, exposed by the `TileDB.CSharp.File` class are obsolete and will be removed in a future version.

### Version introduced

5.17.0

### Recommended action

There is no direct replacement. You can manually store files in TileDB by representing them as one-dimensional dense arrays of bytes.

[core-deprecation]: https://github.com/TileDB-Inc/TileDB/blob/dev/doc/policy/api_changes.md
6 changes: 5 additions & 1 deletion scripts/generate-bindings/GenerateBindings.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,11 @@
<ConfigOption Include="latest-codegen" />
<ConfigOption Include="unix-types" />
<ConfigOption Include="multi-file" />
<Define Include="TILEDB_REMOVE_DEPRECATIONS" />
<!-- <Define Include="TILEDB_REMOVE_DEPRECATIONS" /> -->
<InputFile Include="tiledb/tiledb_experimental.h" />
<TraversePaths Include="$(InputDir)/**/*.h" />
<RemapHandleType Include="array" />
<RemapHandleType Include="array_schema" />
<RemapHandleType Include="attribute" />
<RemapHandleType Include="buffer_list" />
<RemapHandleType Include="buffer" />
Expand All @@ -34,10 +36,12 @@
<RemapHandleType Include="error" />
<RemapHandleType Include="filter_list" />
<RemapHandleType Include="filter" />
<RemapHandleType Include="fragment_info" />
<RemapHandleType Include="group" />
<RemapHandleType Include="query_channel" />
<RemapHandleType Include="query_field" />
<RemapHandleType Include="string" />
<RemapHandleType Include="subarray" />
<RemapHandleType Include="vfs_fh" />
<RemapHandleType Include="vfs" />
<Remap Include="@(RemapHandleType->'tiledb_%(Identity)_handle_t=tiledb_%(Identity)_t')" />
Expand Down
2 changes: 2 additions & 0 deletions sources/TileDB.CSharp/File.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
using System;
using System.ComponentModel;
using TileDB.CSharp.Marshalling.SafeHandles;
using TileDB.Interop;
using ArraySchemaHandle = TileDB.CSharp.Marshalling.SafeHandles.ArraySchemaHandle;

namespace TileDB.CSharp;

[Obsolete(Obsoletions.FilestoreApiMessage, DiagnosticId = Obsoletions.ConfigIteratorDiagId, UrlFormat = Obsoletions.SharedUrlFormat)]
public sealed unsafe class File
{
private readonly Context _ctx;
Expand Down
6 changes: 3 additions & 3 deletions sources/TileDB.CSharp/Group.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,11 +375,11 @@ public string Dump(bool recursive)
{
using var ctxHandle = _ctx.Handle.Acquire();
using var handle = _handle.Acquire();
sbyte* result;
using var result = new StringHandleHolder();
byte int_recursive = (byte)(recursive ? 1 : 0);
_ctx.handle_error(Methods.tiledb_group_dump_str(ctxHandle, handle, &result, int_recursive));
_ctx.handle_error(Methods.tiledb_group_dump_str_v2(ctxHandle, handle, &result._handle, int_recursive));

return MarshaledStringOut.GetStringFromNullTerminated(result);
return result.ToString();
}
#endregion
}
Loading
Loading