Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows has issue with "windows" export in the multiWindow electron helpers #3357

Open
mitchell-foote opened this issue Aug 19, 2024 · 0 comments
Labels
type/bug an issue describing a problem

Comments

@mitchell-foote
Copy link
Contributor

Describe the bug

All of the key combos rely on an export "windows" from the ./multiWindow.js electron helper file. For some reason, that export doesn't work when running on windows, and the key combos don't work.

To Reproduce

Steps to reproduce the behavior:

  1. Go to any windows machine
  2. Open a client
  3. Try to make it a kiosk. It won't work.

Expected behavior

That kiosk + refresh will work.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

I found a solve using the BrowserWindow api, allowing us to keep track of all open windows, and then filter down the ones that aren't the server.

We can then use that list for the key combos.

Pr coming shortly.

@mitchell-foote mitchell-foote added the type/bug an issue describing a problem label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug an issue describing a problem
Projects
None yet
Development

No branches or pull requests

1 participant