Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Atomic Disassembler breaks thermal dynamic ducts incorrectly #82

Open
Magesticles opened this issue Jan 21, 2023 · 4 comments
Open

Comments

@Magesticles
Copy link

Magesticles commented Jan 21, 2023

Describe the bug

Original report:
xJon/The-1.12.2-Pack#858 (comment)
Basically the Atomic disassembler breaks more and gives less of thermal dynamic ducts.

To Reproduce

  1. Have atomic disassembler from Mekanism
  2. Set it to "extended vein mining"
  3. Break any row of Thermal dynamic fluid, flux, item duct, and it will only give you a single one duct despite breaking more.

Expected behavior

You should get every duct broken back, not just the one.

Mekanism Version

Mekanism-1.12.2-9.8.3.390

Minecraft Version is this regarding?

1.12.2

What OS are you seeing the problem on?

Windows

Name of modpack if applicable

1.12.2 pack

Version of said modpack if applicable

1.5.2

Screenshots

No response

The crash report in folder ./crash-reports (both server and client logs)

no crash

Please provide the following other files

https://mclo.gs/JwYWtee

@Magesticles Magesticles changed the title [BUG]: Atomic Disassembler breaks thermal expansion ducts incorrectly [BUG]: Atomic Disassembler breaks thermal dynamic ducts incorrectly Jan 21, 2023
@maggi373
Copy link
Member

i'm quite busy so i'll just gonna disable vein on thermal dynamic ducts.

@Magesticles
Copy link
Author

Thats unfortunate, its nice to destroy a snaking system of power ducts when replacing a power system, or modifying.
I understand though.

@maggi373
Copy link
Member

it depends, i can understand why you want it to do that, but i believe that would involve a rewrite of some code. im quite busy so i dont have time to fix everything. but it will marked as temp fix so others can fix it properly if they want to. we do accept pr's

@jdpatdiscord
Copy link

Hello @maggi373 thank you for maintaining Mekanism 1.7.10/1.12.2 at all. I found this project through sorting popular forks of the Mekanism repo.

On this issue though, the atomic disassembler has a tough time with some multiblock structures other than this. Breaking a digital miner with the disassembler deletes the item entirely.

Mekanism maintainers have vehemently maintained that they will never fix bugs in old versions. It would be great if this was also fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants