Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Fix broken tests in test-with_opt.R #1119

Closed
ilyaZar opened this issue Nov 29, 2023 · 1 comment
Closed

[FR] Fix broken tests in test-with_opt.R #1119

ilyaZar opened this issue Nov 29, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@ilyaZar
Copy link
Contributor

ilyaZar commented Nov 29, 2023 •
edited
Loading

The tests in tests/test-with_opt.R are defunct as the run_app() function is not properly sourced in a dummy-golem.

One can add a call to devtools::load_all() inside the test so the dummy golem has run_app() in its workspace. The test should run in non-interactive mode then.

Can be fixed via #1120
@ilyaZar ilyaZar added the enhancement New feature or request label Nov 29, 2023
@ilyaZar ilyaZar mentioned this issue Nov 29, 2023
Closed
@ColinFay
Copy link
Member

ColinFay commented Aug 7, 2024

Closed via test refactoring

@ColinFay ColinFay closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ColinFay @ilyaZar