Increase test covr. for use_files.R from 0% to 100% [FR]
#1058
Labels
enhancement
New feature or request
Comments
5 tasks
ilyaZar
added a commit
to ilyaZar/golem
that referenced
this issue
Jul 5, 2023
- add some dummy files to the inst/utils/ directory - for later: add tests that download exactly from that directory Refs: ThinkR-open#1058
ilyaZar
changed the title
use_files.R from 0% to 100% [FR]use_files.R from 0% to 100% [FR]
ilyaZar
changed the title
use_files.R from 0% to 100% [FR]use_files.R from 0% to 100% [FR]
This was referenced Jul 5, 2023
Closed
VincentGuyader
pushed a commit
that referenced
this issue
Aug 8, 2023
…0 to 100% (#1059) * tests: add dummy files for use_{external,internal}_XXX_files() testing - add some dummy files to the inst/utils/ directory - for later: add tests that download exactly from that directory Refs: #1058 * tests: add testing for external-funcs standard cases * tests: add testing for internal-funcs standard cases - fix typo in testfile_template_html - use styler::style_file(..., style = grkstyle::grk_style_transformer) * fix: set default value for argument name before using it - the order needs a change at some places: first set a default value when name argument is missing - only then call check_name_length() to avoid errors of the type: "argument "name" is missing, with no default" - also, to avoid RStudio and other IDEs linting a missing argument, provide a default value "NULL" for argument 'name' Refs: #1060 * feat: improve error handling and allow codecovr. to be 100% - instead of throwing an error, return 'FALSE' is passed and cat_dir_necessary() prints an informative message to the user (with the same effect i.e. not creating a directory) - this behavior is a bit more userfriendly and also allows for a code coverage of 100%; the latter is not possible to implement since tests are run non-interactively * tests: add corner cases for tests to make covr. 100%
VincentGuyader
added a commit
that referenced
this issue
Aug 8, 2023
* Fix 1058, 1060, 1062 and improve code coverage in `use_files.R` from 0 to 100% (#1059) * tests: add dummy files for use_{external,internal}_XXX_files() testing - add some dummy files to the inst/utils/ directory - for later: add tests that download exactly from that directory Refs: #1058 * tests: add testing for external-funcs standard cases * tests: add testing for internal-funcs standard cases - fix typo in testfile_template_html - use styler::style_file(..., style = grkstyle::grk_style_transformer) * fix: set default value for argument name before using it - the order needs a change at some places: first set a default value when name argument is missing - only then call check_name_length() to avoid errors of the type: "argument "name" is missing, with no default" - also, to avoid RStudio and other IDEs linting a missing argument, provide a default value "NULL" for argument 'name' Refs: #1060 * feat: improve error handling and allow codecovr. to be 100% - instead of throwing an error, return 'FALSE' is passed and cat_dir_necessary() prints an informative message to the user (with the same effect i.e. not creating a directory) - this behavior is a bit more userfriendly and also allows for a code coverage of 100%; the latter is not possible to implement since tests are run non-interactively * tests: add corner cases for tests to make covr. 100% * chore bump coverage --------- Co-authored-by: Ilya Zarubin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Two benefits:
use_{external,internal}_XXX_files()function family living inuse_files.R(as requested e.g. here Add replace arg to use_external #819 )Can be fixed by #1059
The text was updated successfully, but these errors were encountered: