Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Division by zero in Mclimate Vicki uplink formatter #836

Open
Lukasz-Bialy opened this issue Oct 18, 2024 · 1 comment
Open

Division by zero in Mclimate Vicki uplink formatter #836

Lukasz-Bialy opened this issue Oct 18, 2024 · 1 comment
Assignees

Comments

@Lukasz-Bialy
Copy link

Summary

Mclimate Vicki uplink formatter has a bug in a calculation of the motorOpenness, in case where motorRange parameter(in device) is set to 0, formatter is trying to divide motorPosition by 0, because of that the whole uplink message from device in TTS is empty and there's a message about NaN value in motorOpenness.
Mclimate on their website for the Vicki device, have new uplink formatter, and case when motorRange=0 is secured.
...

What do you see now?

I see on the TTS website, empty uplink message from the Mclimate Vicki device, json which should normally be visible is empty, even when the message itself is fine

...

What do you want to see instead?

I want to see formatted uplink message from the device, with properly calculated motorOpenness

...

How do you propose to implement this?

Copy formatter from Mclimate Vicki official website and update file lorawan-devices/vendor/mclimate/vicki.js from your repository
Link to Mclimate documentation:
https://docs.mclimate.eu/mclimate-lorawan-devices/devices/mclimate-vicki-lorawan/vicki-uplink-decoder

...

Can you do this yourself and submit a Pull Request?

If you allow me to submit Pull Request to your repository
...

@github-actions github-actions bot added the needs/triage We still need to triage this label Oct 18, 2024
@KrishnaIyer
Copy link
Member

@Lukasz-Bialy: You can indeed create a PR and we'll review it. Thanks a lot!

@KrishnaIyer KrishnaIyer removed the needs/triage We still need to triage this label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants