Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance validation #108

Open
johanstokking opened this issue Jan 28, 2021 · 1 comment
Open

Enhance validation #108

johanstokking opened this issue Jan 28, 2021 · 1 comment
Assignees

Comments

@johanstokking
Copy link
Member

johanstokking commented Jan 28, 2021

Summary

Enhance validation

Why do we need this?

To reduce errors and time spend on trial and error.

What is already there? What do you see now?

Validation works, but there are still things that can slip through.

What is missing? What do you want to see?

I want to make validation check more things. I also want the output to be clearer. Finally I want to be able to validate only one vendor at a time.

How do you propose to implement this?

  1. Check casing of filenames; everything should be lowercase (done)
  2. Check if there are vendors in the vendor folder which are not in de vendor/index.yaml. This catches cases where people accidentally forgot to add the vendor entry
  3. Be able to pass an argument to the validation script, to only validate a specific vendor
  4. Check if the vendor has a vendor ID issued by the LoRa Alliance. If not, make sure that vendorProfileID in the profiles are empty (0), as they should be
  5. LoRaWAN checks; we may want to add schema validation that the maximum EIRP does not exceed the regulatory limits. Not sure if we can make this water tight, but we can catch some common mistakes here

Can you do this yourself and submit a Pull Request?

Yes

@johanstokking johanstokking added this to the February 2021 milestone Jan 28, 2021
@johanstokking johanstokking self-assigned this Jan 28, 2021
@johanstokking johanstokking modified the milestones: March 2021, Backlog Mar 1, 2021
@neoaggelos
Copy link
Contributor

Adding to the list in the description:

  • Verify that the specified codec files exist (extra; and are valid Javascript)

@htdvisser htdvisser removed this from the Backlog milestone Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants