Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the ExecutionService base class throw TimeoutException on failed execute #80

Open
dankwart-de opened this issue Nov 30, 2017 · 2 comments
Milestone

Comments

@dankwart-de
Copy link
Contributor

dankwart-de commented Nov 30, 2017

LSF e.g. will just block and retry command submission, PBS does not (or at least our installation). Or it depends on the configuration and that can lead to funny behaviour. Anyways the developer should be aware of the fact and the TimeoutException might do just the right thing. Currently BE only offers the base class or interface, but this can then be used to force the exception.

@vinjana
Copy link
Contributor

vinjana commented Nov 30, 2017

So three things need to be done:

  1. Add throws TimeoutException to ExecutionService and let it actually throw the exception if the timeout is reached.
  2. Add throws TimeoutException to BEJobManager.runJob() and its subclasses
  3. Handle the TimeoutException in the Roddy client code (e.g. by dying and displaying a messege.).

@vinjana
Copy link
Contributor

vinjana commented Feb 12, 2018

Related to #79.

@vinjana vinjana added this to the Release 1.0 milestone Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants