Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable text chat during vote to allow SPACEBAR to raise / lower hand #199

Open
StewieGriffin opened this issue Jul 26, 2024 · 4 comments
Open
Assignees
Labels
feature New feature or request

Comments

@StewieGriffin
Copy link

StewieGriffin commented Jul 26, 2024

Description

After nominations, when voting starts (the clock hand starts moving), if a player is focused on the chat window, the spacebar does not work for voting (a space is just added in the chat window).
This has influenced a few games I've played.

An easy fix would be for the app to automatically remove focus from the chat (or disable the chat window) during voting.

Steps to reproduce

  1. Player starts typing something in chat
  2. ST starts the vote
  3. Player presses --spacebar-- trying to vote, but a space is just added in chat and vote doesn't count

Browser

Chrome

Operating System

Windows

Date and Time

July, 25, 01h00 GMT

Game Session

No response

Relevant console log output

No response

@StewieGriffin StewieGriffin added bug Something isn't working triage This issue still needs to be evaluated labels Jul 26, 2024
@bra1n
Copy link
Member

bra1n commented Jul 26, 2024

Hi there, this isn't really a bug - when you are entering a chat message, none of the shortcuts are working, because you probably don't intend to use a shortcut if you press the associated letter key. With the latest update, you can tab out of the chat box by pressing TAB, which allows your shortcuts to be used again.
Disabling text chat during a vote is probably a sensible feature request, but I'll have to think about it.

@bra1n bra1n added feature New feature or request and removed bug Something isn't working triage This issue still needs to be evaluated labels Jul 26, 2024
@bra1n bra1n changed the title [BUG] Issue with spacebar during voting Disable text chat during vote to allow SPACEBAR to raise / lower hand Jul 26, 2024
@bra1n bra1n self-assigned this Jul 26, 2024
@Unbaloav
Copy link

Unbaloav commented Aug 7, 2024

I would disagree with this, since people (at least me) sometimes like to add something to an accusation or defense via chat if it isn't possible to add something verbaly, because one wouldn't like to make the ST add a Hell's Librarian because it is getting too chaotic. (Or one just isn't able to talk over others.) Also if you start writing something in chat and then a nom starts it would be a bit annoying if you can't continue writing it.

@StewieGriffin
Copy link
Author

A solution for that would be to add it as an option in Settings, so players who want the feature can enable it without annoying those who don't.

@bra1n
Copy link
Member

bra1n commented Aug 12, 2024

I would disagree with this, since people (at least me) sometimes like to add something to an accusation or defense via chat if it isn't possible to add something verbaly, because one wouldn't like to make the ST add a Hell's Librarian because it is getting too chaotic. (Or one just isn't able to talk over others.) Also if you start writing something in chat and then a nom starts it would be a bit annoying if you can't continue writing it.

What I meant would only apply to the actual vote though - during the accusation and defense, people would still be able to chat. As soon as the vote itself begins, the text chat could be disabled and people could use their vote shortcut, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Development

No branches or pull requests

3 participants