Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button Icons (and other UI elements) are not visible in some High Contrast Theme #355

Open
nchevobbe opened this issue Nov 22, 2024 · 1 comment
Open

Button Icons (and other UI elements) are not visible in some High Contrast Theme #355

nchevobbe opened this issue Nov 22, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@nchevobbe
Copy link

Describe the bug
In Night Sky High Contrast Theme, the button background color is black, as are the icons, which makes them "invisible"

Desktop (please complete the following information):

  • OS: Windows 11

To Reproduce
Select Night Sky High Contrast Theme in the OS settings (https://support.microsoft.com/en-us/windows/change-color-contrast-in-windows-fedc744c-90ac-69df-aed5-c8a90125e696)

Expected behavior
The icons should be visible

Screenshots

image
@ferllings ferllings added the bug Something isn't working label Nov 22, 2024
@nchevobbe
Copy link
Author

I'll try to fix this myself, using @media (forced-colors: active) in the SVG files to set the right colors maybe

ungjinPark pushed a commit to ungjinPark/CCAe that referenced this issue Nov 28, 2024
Improve color contrast of the fail/pass icon
7852250 
The contrast mode issue(ThePacielloGroup#355, ThePacielloGroup#356) prompted me to revisit the color contrast of the CCA user interface.

I identified issues with color contrast across various screen theme modes (e.g., Windows Contrast Theme, Dark Mode, Light Mode), particularly with the fail (X mark) and pass (check mark) icons.

To address this, I adjusted the colors to ensure a contrast ratio of at least 4.5:1 in all modes (Light, Dark, and Contrast Mode).
@ungjinPark ungjinPark mentioned this issue Nov 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nchevobbe @ferllings