Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolkit incorrectly marks disabled button as having an insufficient color contrast error #50

Open
kirbykatie opened this issue Dec 14, 2023 · 4 comments
Labels
bug Something isn't working rules engine

Comments

@kirbykatie
Copy link

Describe the bug

Running the toolkit on a page with a disabled button, the toolkit shows an error and identifies that button as not having enough color contrast (the button is light gray with white text).

Sufficient color contrast is not needed for disabled elements, according to WCAG 2.0.

To Reproduce

Identify any steps required to reproduce the behavior and/or link to a test case that demonstrates the issue.

  1. Create or find a webpage with the following markup:
    <button disabled>Test</button>
    and with the following styling:
    button:disabled { background-color: #e8e5e1; color: #ffffff; }
  2. Run the ARC toolkit to confirm error.

Expected behavior

There should be no error regarding color contrast for disabled buttons.

Screenshots

disabled-error

Markup of button:
markup

Version information

  • Browser and version: Chrome 120.0.6099.71
  • ARC Toolkit version: 5.6.0

Additional context

Add any other context about the problem here.

@ferllings ferllings added bug Something isn't working rules engine labels Dec 15, 2023
@aaronbnb
Copy link

Thank you @kirbykatie this is a great bug report and a bug that is correctable via automated means.

@kirbykatie
Copy link
Author

Thank you for looking into it! I also just learned another team we're working with found the same issue with a disabled checkbox, so I just want to flag that all disabled HTML elements should not get an insufficient color contrast error.

@kirbykatie
Copy link
Author

Hello! Following up on this - is there a an upcoming release where this issue is expected to be resolved?

@ferllings
Copy link
Member

Sorry for the delay. The next release will include this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rules engine
Projects
None yet
Development

No branches or pull requests

3 participants