Fix: Allow table rendering in markdown preview tool #4858
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
Some of our lessons have markdown tables but the necessary table tags (table/thead/tbody/tr/th/td) are not included in rails-html-sanitizer's default allowed tags, meaning our markdown preview tool won't render tables.
This PR
Markdown::PreviewComponent#allowed_tags
.Issue
N/A
Additional Information
For QA
Go to the markdown preview tool and enter
Which will fail to render the table (which renders properly in the actual lessons):
Compare that to when the 6 relevant tags are whitelisted in
#allowed_tags
, which allows rendering of markdown tables as expected as below:Pull Request Requirements
keyword: brief description of change
format, using one of the following keywords:Feature
- adds new or amends existing user-facing behaviorChore
- changes that have no user-facing value, refactors, dependency bumps, etcFix
- bug fixesBecause
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section