Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue - Update ruby version #4840

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

karimdevelops
Copy link
Contributor

Because

This pull request links to my prev pull request
I have bumped it in the main repo

This PR

  • Bump ruby version to 3.3.5 in main repo

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. String spec: Update instructions for clarity
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If this PR includes changes in the spec folder, they are also updated in the corresponding file in the spec_answers folder (with passing tests).

@karimdevelops karimdevelops changed the title Bump ruby version to 3.3.5 Continue - Update ruby version Oct 21, 2024
Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you for contributing.

I can see that you created this PR from the main branch of your fork. I recommend not doing this in the future. Create a topic branch in your local clone:

# from `main` branch
git checkout -b branch_for_my_feature # this command will create the branch and change to it

# then make your changes like normal and commit and push them

This allows you to easily track main if you ever need to merge it in. But if you're working changes are on main, this becomes a huge headache.

Just some advise that can help avoid trouble down the line.

@JoshDevHub JoshDevHub merged commit f4fa844 into TheOdinProject:main Oct 22, 2024
5 checks passed
@karimdevelops
Copy link
Contributor Author

This is my 3rd contribution to TOP! yea not something huge but still... its not bad
Anyway, thanks @JoshDevHub. I appreciate your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants