-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A Deeper Look at Git: <Amended Q3 and links in Knowledge Check to reflect lesson content> #29111
A Deeper Look at Git: <Amended Q3 and links in Knowledge Check to reflect lesson content> #29111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just one small thing to fix to simplify the knowledge check hrefs, and then I'll merge this in.
- [How can you amend your last commit?](https://www.theodinproject.com/lessons/javascript-a-deeper-look-at-git#changing-the-last-commit) | ||
- [What are some different ways to rewrite history?](https://www.theodinproject.com/lessons/javascript-a-deeper-look-at-git#changing-multiple-commits) | ||
- [What does it mean for branches to be pointers?](https://www.theodinproject.com/lessons/javascript-a-deeper-look-at-git#branches-are-pointers) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [How can you amend your last commit?](https://www.theodinproject.com/lessons/javascript-a-deeper-look-at-git#changing-the-last-commit) | |
- [What are some different ways to rewrite history?](https://www.theodinproject.com/lessons/javascript-a-deeper-look-at-git#changing-multiple-commits) | |
- [What does it mean for branches to be pointers?](https://www.theodinproject.com/lessons/javascript-a-deeper-look-at-git#branches-are-pointers) | |
- [How can you amend your last commit?](#changing-the-last-commit) | |
- [What are some different ways to rewrite history?](#changing-multiple-commits) | |
- [What does it mean for branches to be pointers?](#branches-are-pointers) |
Because these links all reference ids on this page, the href for all of them can be simplified to just have the id rather than the full URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting that and for the suggestion - I've fixed it now :-)
Because
the Knowledge check Q1 (now Q3) needed changing to a question and all links needed updating to reflect material covered in the lesson.
This PR
Issue
Closes #29108
Additional Information
NA
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section