Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Deeper Look at Git: <Amended Q3 and links in Knowledge Check to reflect lesson content> #29111

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

Meltasy
Copy link
Contributor

@Meltasy Meltasy commented Nov 22, 2024

Because

the Knowledge check Q1 (now Q3) needed changing to a question and all links needed updating to reflect material covered in the lesson.

This PR

  • changed Q1 to a question in the Knowledge Check section
  • moved Q1 to Q3 in the Knowledge Check section, and moved Q2 to Q1 and Q3 to Q2
  • changed Q1 link in the Knowledge Check section to para headed 'Changing the last commit'
  • changed Q2 link in the Knowledge Check section to para headed 'Changing multiple commits'
  • changed Q3 link in the Knowledge Check section to para headed 'Branches are Pointers'
  • Removed the extra space in the Assigment list, as per TOP style

Issue

Closes #29108

Additional Information

NA

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Git Involves Git content label Nov 22, 2024
Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one small thing to fix to simplify the knowledge check hrefs, and then I'll merge this in.

Comment on lines 153 to 155
- [How can you amend your last commit?](https://www.theodinproject.com/lessons/javascript-a-deeper-look-at-git#changing-the-last-commit)
- [What are some different ways to rewrite history?](https://www.theodinproject.com/lessons/javascript-a-deeper-look-at-git#changing-multiple-commits)
- [What does it mean for branches to be pointers?](https://www.theodinproject.com/lessons/javascript-a-deeper-look-at-git#branches-are-pointers)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [How can you amend your last commit?](https://www.theodinproject.com/lessons/javascript-a-deeper-look-at-git#changing-the-last-commit)
- [What are some different ways to rewrite history?](https://www.theodinproject.com/lessons/javascript-a-deeper-look-at-git#changing-multiple-commits)
- [What does it mean for branches to be pointers?](https://www.theodinproject.com/lessons/javascript-a-deeper-look-at-git#branches-are-pointers)
- [How can you amend your last commit?](#changing-the-last-commit)
- [What are some different ways to rewrite history?](#changing-multiple-commits)
- [What does it mean for branches to be pointers?](#branches-are-pointers)

Because these links all reference ids on this page, the href for all of them can be simplified to just have the id rather than the full URL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting that and for the suggestion - I've fixed it now :-)

@JoshDevHub JoshDevHub merged commit 4e41f5e into TheOdinProject:main Nov 25, 2024
2 checks passed
@Meltasy Meltasy deleted the knowledge_check_updates branch November 25, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Git Involves Git content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A Deeper Look at Git: <Change Knowledge check Q1 to a question and update links to material covered in lesson>
3 participants