Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Validation with JavaScript: Change to questions in Knowledge Check #28980

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

Meltasy
Copy link
Contributor

@Meltasy Meltasy commented Oct 21, 2024

Because the questions in the Knowledge Check section needed rewritting as statements, and the final question needed removing to avoid repetition.

This PR

  • rewrites the Knowldge Check statements as questions
  • removes the final question which is already answered in the second question

Issue

Closes #28969

Additional Information

NA

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: JavaScript Involves the JavaScript course label Oct 21, 2024
@MaoShizhong MaoShizhong merged commit 274672b into TheOdinProject:main Oct 21, 2024
3 checks passed
@Meltasy Meltasy deleted the knowledge_check_updates branch October 21, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: JavaScript Involves the JavaScript course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form Validation with JavaScript: Change to questions in Knowledge Check
2 participants