Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Practice: Explicitly state difference from example #28954

Closed
wants to merge 1 commit into from

Conversation

softy-dev
Copy link
Contributor

Because

I think that for the benefit of clarity, if what the assignment proposes is different from the reference that is linked, it should be stated explicitly to leave no ambiguity if it was intentional or an oversight.

This PR

  • Adds some detail to one of the assignment's bullet points that specifies that it should be done differently than what was shown (keep original lettercase instead of all uppercase).

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: JavaScript Involves the JavaScript course label Oct 14, 2024
@wise-king-sullyman wise-king-sullyman requested review from a team and zachmmeyer and removed request for a team October 14, 2024 23:20
@linkonsat
Copy link
Contributor

linkonsat commented Oct 17, 2024

I think that could make it a bit more confusing. The instructions specify what the conditions to follow and an example. It came off as a bit confusing to add that to me as I could see someone reading it and being confused if they were supposed to use the link for the first cipher test. As they should get the same result as the examples below the article and they would benefit from asking how to achieve it on the Discord. I do appreciate it however!

@linkonsat linkonsat closed this Oct 17, 2024
@softy-dev softy-dev deleted the patch-1 branch October 26, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: JavaScript Involves the JavaScript course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants