-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All HTML/CSS assignments: Update lessons to reflect restructured css-exercises repo #28922
All HTML/CSS assignments: Update lessons to reflect restructured css-exercises repo #28922
Conversation
…ted repo structure
…ed repo structure
@MaoShizhong I am unable to request a review. I am assuming that there is some sort of access control preventing me from doing so. (Pinging you since you instructed me to request a review from you.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing these. I feel like some of the links text labels fit the situation as well now, especially since some of them imply that the link will take people to the CSS exercises repo, then instructs them to navigate to a directory. I can see some confusion occuring when the link takes them to a place where those directories don't exist.
Perhaps if all of the relevant assignment steps could be reworded to something like the following (suggestion only):
Do the exercises in our CSS exercises repository's
intermediate-html-css/advanced-grid
directory (remember that the instructions are in the README):
Then those links will also make more sense with assistive tech, e.g. a link navigator will have
CSS exercises repository's intermediate-html-css/advanced-grid directory - link
instead of
CSS exercises repository and do the exercises within the intermediate-html-css/advanced-grid directory - link
.
Thoughts?
@MaoShizhong I think your suggestion would be best. I am not the biggest fan of repetition, but in this case, I think it would be completely okay to use the exact same wording for all of the assignments:
(I used a dummy link for this example) These links are "scattered" throughout the curriculum (as opposed to being all in one place), so the fact that they all use that wording probably won't even be noticeable. Additionally, it may increase the user's familiarity with CSS assignments, so perhaps it will make it easier to spot the CSS exercises throughout the lessons. I can go ahead and update all the assignments so they look like that example if you would like, or did you think we should do something different? |
If you can go ahead and update the relevant assignment steps for each lesson to follow that kind of wording and allow for the link text format above, that'd be awesome 👍 |
@MaoShizhong I apologize if the pings are unnecessary (please let me know if they are). I updated the exercises so they follow (more-or-less) this wording:
I did have a slight concern that throwing in the reminder would break the flow of the sentence, and was considering rewording it to
However, the latter version would indeed make it appear too repetitive for my liking. Please let me know if you need any changes to be made. |
Additionally, the very first CSS assignment gets an exception since it is the first time the reader is introduced to it. Thus, I left that one as:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Because
we agreed to restructure the
css-exercises
repo in order to improve discoverability and clarity (see related Issue).It also helps avoid user error when having to navigate a confusing directory structure that does not reflect TOP's curriculum structure.
This PR
Issue
Related to TheOdinProject/css-exercises#593
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section