Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermediate HTML and CSS, advanced selectors: fix broken css-tricks.com links #28883

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

Strange-can
Copy link
Contributor

@Strange-can Strange-can commented Oct 1, 2024

Because

links to css-tricks.com under pseudo-classes and pseudo-elements were broken.

This PR

  • changed the "selectors" part of the link to "pseudo-selectors"

  • the ::before and ::after link also got the "a" part changed to "b"

Issue

Closes #28876

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course label Oct 1, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing all these links.

@MaoShizhong MaoShizhong merged commit 33a9979 into TheOdinProject:main Oct 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced Selectors: links to all css-tricks.com pages gives a 404 error page
2 participants