Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Complexity: Fix subject-verb agreement in introduction section #28874

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

Maddily
Copy link
Contributor

@Maddily Maddily commented Sep 29, 2024

Because

The subject "requirements" is plural, so the verb should be "grow" instead of "grows."

This PR

Fixes subject-verb agreement in introduction section by changing "even as the requirements for it grows" to "even as the requirements for it grow."

Issue

Closes #XXXXX

Additional Information

N/A

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: JavaScript Involves the JavaScript course label Sep 29, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the grammar fix. To appease the linter, could you put a backslash before each of the * on lines 224 and 228 to escape them? Currently they're unescaped and the linter sees them as emphasis markers instead of plain asterisks.

@Maddily
Copy link
Contributor Author

Maddily commented Sep 29, 2024

Done

@MaoShizhong MaoShizhong merged commit baa99a2 into TheOdinProject:main Sep 29, 2024
2 checks passed
@Maddily Maddily deleted the patch-2 branch September 29, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: JavaScript Involves the JavaScript course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants