Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Up Git: Clarify git email options #28864

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

lukegrob
Copy link
Contributor

Because

Due to some confusion around private emails in the github setup, people were were sometimes surprised that gitHub rejected their pushes as they had previously enabled that option in setup.

This PR

  • Emphasizes in step 2.1 that they should keep track of their private email (if used) for later
  • Rewords the explanation directly around the e-mail config lines to make sure they know that is where they're intended to use it.

Issue

Closes #28739

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label Sep 25, 2024
@MaoShizhong MaoShizhong merged commit b50d89f into TheOdinProject:main Sep 26, 2024
3 checks passed
@lukegrob lukegrob deleted the clarify_git_email_options branch September 26, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Foundations Setting up Git: Clarify git e-mail config section to eliminate confusion
2 participants