Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working with APIs : Added new assignment #28860

Closed
wants to merge 5 commits into from
Closed

Conversation

kichuu
Copy link
Contributor

@kichuu kichuu commented Sep 25, 2024

Because

It would be helpful for people who understand better when concept is explained in a video.

This PR

Added a video on Fetch API in assignments

Issue

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: JavaScript Involves the JavaScript course label Sep 25, 2024
@JoshDevHub JoshDevHub requested review from a team and wise-king-sullyman and removed request for a team October 2, 2024 17:20
Copy link
Member

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to make this PR.

Does this video provide new information, or just repeat previously covered information in a different format?

@kichuu
Copy link
Contributor Author

kichuu commented Oct 13, 2024

Thank you for taking the time to make this PR.

Does this video provide new information, or just repeat previously covered information in a different format?

I'd say yes and no. Almost 70% of info in the video is covered in the current curriculum.. I personally think a bit more info on the topic would be good and very helpful for visual learners.

@wise-king-sullyman
Copy link
Member

Thanks again for making this PR, but since the video does seem to be adding little to no new information to the lesson I think we want to keep the assignments as they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: JavaScript Involves the JavaScript course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants