-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Form Basics: Fixes grammatical error #28856
Form Basics: Fixes grammatical error #28856
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the grammar fixes. It looks like you have Prettier running on save - we use a different style guide to Prettier, which has caused it to change a lot more than you intended. We will need all of the changes reverted except of course the intended grammar fixes. So that includes all the HTML changes like spacing, self-closing tags etc.
You should get used to using "save without formatting" when working with external projects as they may not always use the same rules as your local auto-formatter, like in this case.
@june062 You don't need to close a PR and make a new one if changes are required. A PR just tracks a branch so you can just commit and push changes to that branch and it'll auto update here. |
Ok, sorry about that. I'm getting so confused trying to revert my fork to how it was before I pushed my changes lol |
No worries - just a heads up because a few times people have thought PRs are one-shot only and didn't realise it's just tracking a branch they can commit changes to :) |
63d1501
to
95dfd9d
Compare
Okay, I believe it's correct now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Because
This PR corrects a small grammar mistake in the assignment section of the "Form Basic," lesson.
This PR
Issue
Closes #28855
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section