Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Basics: Fixes grammatical error #28856

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

june062
Copy link
Contributor

@june062 june062 commented Sep 24, 2024

Because

This PR corrects a small grammar mistake in the assignment section of the "Form Basic," lesson.

This PR

  • Changed all instances of the phrase "Read and follow along to..." to "Read and follow along with..." within the assignment section.

Issue

Closes #28855

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course label Sep 24, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the grammar fixes. It looks like you have Prettier running on save - we use a different style guide to Prettier, which has caused it to change a lot more than you intended. We will need all of the changes reverted except of course the intended grammar fixes. So that includes all the HTML changes like spacing, self-closing tags etc.

You should get used to using "save without formatting" when working with external projects as they may not always use the same rules as your local auto-formatter, like in this case.

@june062 june062 closed this Sep 24, 2024
@june062 june062 deleted the form-basics-fix-grammar branch September 24, 2024 19:18
@MaoShizhong
Copy link
Contributor

@june062 You don't need to close a PR and make a new one if changes are required. A PR just tracks a branch so you can just commit and push changes to that branch and it'll auto update here.

@june062 june062 restored the form-basics-fix-grammar branch September 24, 2024 19:23
@june062 june062 reopened this Sep 24, 2024
@june062
Copy link
Contributor Author

june062 commented Sep 24, 2024

Ok, sorry about that. I'm getting so confused trying to revert my fork to how it was before I pushed my changes lol

@MaoShizhong
Copy link
Contributor

No worries - just a heads up because a few times people have thought PRs are one-shot only and didn't realise it's just tracking a branch they can commit changes to :)

@june062 june062 closed this Sep 24, 2024
@june062 june062 force-pushed the form-basics-fix-grammar branch from 63d1501 to 95dfd9d Compare September 24, 2024 19:29
@june062 june062 reopened this Sep 24, 2024
@june062
Copy link
Contributor Author

june062 commented Sep 24, 2024

Okay, I believe it's correct now

Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MaoShizhong MaoShizhong merged commit 8d9d00c into TheOdinProject:main Sep 24, 2024
4 checks passed
@june062 june062 deleted the form-basics-fix-grammar branch September 25, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermediate HTML and CSS: Minor grammar error in the "Form Basics" lesson
2 participants