Authentication Basics lesson: Fix undefined user error #28840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple issue that has not yet been opened. It was not implied as imperative to the Image Slider exercise to watch the video on transitions, but it is necessary to Image Slider step 3 as an introduction to CSS transitions. Changes: Line 9: Clarify that the video demonstrates CSS transitions. Line 42: Reference the transitions video for added clarity.
Reference user from locals property in order to avoid a reference error if user has not been set to the locals object Changes: Line 254: reference user as locals.user
Figby222
changed the title
Figby222
changed the title
MaoShizhong
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
In the login form EJS template, if the user is not defined whilst rendering the template the application will throw a reference error. This is because, in the if statement checking whether user is defined, user is being referenced simply as user, and not from locals.user. This PR solves that by simply referencing user from locals.user
This PR
Issue
Closes #XXXXX
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection