Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Manager project: Update google apis installation instruction #28827

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

PivtoranisV
Copy link
Contributor

Because

It prevents signet errors because Bundler is smart enough to check against the Ruby version requirement and find a set of gem releases that will satisfy the environment.
Also, it will be a good practice to do this in such a way, as was described in the Project Management lesson

This PR

  • Updates commands to install Google API
  • Update command to run project with bundler
  • Update the description of what we are doing

Issue

Closes #27694

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Ruby Involves the Ruby course label Sep 20, 2024
Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this PR. Going to request a few changes before merging.

ruby/files_and_serialization/project_event_manager.md Outdated Show resolved Hide resolved
ruby/files_and_serialization/project_event_manager.md Outdated Show resolved Hide resolved
ruby/files_and_serialization/project_event_manager.md Outdated Show resolved Hide resolved
ruby/files_and_serialization/project_event_manager.md Outdated Show resolved Hide resolved
Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for working on this.

@JoshDevHub JoshDevHub merged commit 7f88851 into TheOdinProject:main Oct 3, 2024
1 of 2 checks passed
@PivtoranisV PivtoranisV deleted the issue-27694 branch October 4, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Ruby Involves the Ruby course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GEvent Manager: Fix google api installation
2 participants