Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Transform: Replace link text and source #28755

Merged
merged 1 commit into from
Sep 7, 2024
Merged

CSS Transform: Replace link text and source #28755

merged 1 commit into from
Sep 7, 2024

Conversation

c8in4
Copy link
Contributor

@c8in4 c8in4 commented Sep 7, 2024

Because

The previous resource in the second Assignment included several inaccuracies that led to confusion.

This PR

Issue

Closes #28708

Additional Information

Discord conversation on the contradicting info for transform order

Lesson Url

https://www.theodinproject.com/lessons/node-path-advanced-html-and-css-transforms#assignment

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Update 2nd Assignment:
Link replaced with: (https://3dtransforms.desandro.com/perspective)

Link text label is changed from [the `perspective` property on CSS tricks] to [perspective in CSS].
@github-actions github-actions bot added the Content: Advanced HTML/CSS Involves the Advanced HTML/CSS course label Sep 7, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first PR here 🚀

@MaoShizhong MaoShizhong merged commit 82ac418 into TheOdinProject:main Sep 7, 2024
3 checks passed
@c8in4
Copy link
Contributor Author

c8in4 commented Sep 7, 2024

Thank you, @MaoShizhong,
That was exciting! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Advanced HTML/CSS Involves the Advanced HTML/CSS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transforms: Replace assigned article on CSS Perspective
2 participants