Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Types and Conditionals: Edit a Knowledge check question #28712

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

youssef-el-atmani
Copy link
Contributor

Removed a questions about a deprecated String Method: substr()

Because

Because the substr() method is deprecated: String.prototype.substr()

This PR

-Remove a word from a knowledge question that is related to a deprecated String method

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Removed a questions about a deprecated String Method: substr()
@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label Aug 28, 2024
Copy link
Member

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change, thanks!

@wise-king-sullyman wise-king-sullyman merged commit bbeae1f into TheOdinProject:main Aug 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants